[MPlayer-dev-eng] [PATCH] libdvdnav API changes

[Jonas Jermann]

Hi

On Thu, Aug 08, 2002 at 05:07:53AM +0200, Sylvain Petreolle wrote:
> > Could someone please overlook/check it before (if) it gets 
> > commited (I don't know how to do such things). At least it 
> > compiled for me after the patch.
> Compiles fine for me.
> RedHat 7.3/ gcc3 3.1-5, IDE LG DVD-ROM DRD-8160B, libdvdnav today cvs.
> Great work !
thx

> > Btw, libdvdnav is still unusable IMHO:
> >     It freezed when I wanted to select the language
> What did you to produce a freeze ? (provide cmd line/ step to reproduce
> it)

Hmm, It freezed for language selection with "The Matrix" dvd, 
worked for some others... I think it has sthg to do with the 
still frames which aren't properly integrated at the moment 
(donno ?).

> >     The buttons aren't highlighted/marked (did someone else get 
> >       highlighted buttons? I just got a text output)
> The fact is that no key is assigned to handle such things.
> Give the text output you have ?

ö? There is a key assigned but I didn't get any visual 
"feedback". The text message was (example):
DVDNAV Event: Highlight button 3 (0,12760)-(0,12632) PTS 819462144 (now is 26.49)
 
> >     Playback is slow (no cache, cd device settings didn't help)
> Speed is ok for me (my LG is a basic one) with a Nvidia Geforce 2.

good for you...

> >     Can't seek...
> no problem here (success with 10s, 1 min, 10 min, back and forward)

ö? Now I'm confused... I always get a "Cannot seek in DVDNAV 
streams yet!" (it just jumps about 10s never more) and afaik it 
isn't implemented yet in dvdnav/mplayer.

> >     Skipopening didn't work for me
> how to see if this is successfull in mplayer output ?
> I just tried 'mplayerr -dvdnav -skiopening' and got the movie playing.

Donno, I didn't see any difference between normal -dvdnav (got 
the menu, not the movie).

> Agreed, as the buttons don't work and then don't launch the movie.
> But that's beautiful.

ö? What do you mean? The button worked for me...

> > I hope that someone takes a look at it, mpdvdkit etc again
> > and improves dvd supprot for mplayer. This patch just let it 
> > compile again...

MPlayer is not designed to use libdvdnav or to handle such
interactive things (and mouse navigation and much more).
It would need a restructure which won't happen for the next
few years... IMHO someone should separate all libdvdnav
functions and integrate them in MPlayer to let MPlayer handle
all the stuff on it's own way (not through libdvdnav).
Otherwise it's just a big unusable mess. I'd even delete it
or move it to unapplied patches if nobody is interested to
work on it (Kees Cook ;).
I only needed it to play dvds with complex title id sets
(20 title ids, main movie: 6,7,16,17,18) and I hate menus ;)

I'd more like an option to guess the main movie than those menus 
(as in dvdbackup).


Best Regards
    Jonas