[MPlayer-dev-eng] 10l bug in network code?

[Felix Buenemann]

On Monday 05 August 2002 02:31, Arpi wrote:
> Hi,
>
> while reviewing teh live.com patch, i've found this in network.c,
> seems to be some debug code, forgotten to remove:
>
>                 // Get the extension of the file if present
>                 if( url->file!=NULL ) {
>                         for( i=strlen(url->file) ; i>0 ; i-- ) {
>                                 if( url->file[i]=='.' ) {
>                                         extension=(url->file)+i+1;
>                                         break;
>                                 }
>                         }
>                 }
> extension=NULL;
>                 if( extension!=NULL ) {
>                   mp_msg(MSGT_NETWORK,MSGL_DBG2,"Extension: %s\n",
> extension); // Look for the extension in the extensions table ...
>
> note that line 'extension=NULL;'
>
> is it a workaround for something or it was added to test/debug something
> and commited by accident?

I guess you are right, that it's debug code, rev 1.9 to 1.10 has this:
---
-//     extension=NULL; 
+extension=NULL;        
                if( extension!=NULL ) {
---

The commit was by Bertrand Baudet, so he should check it.

> A'rpi / Astral & ESP-team
>
> --
> Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu
> _______________________________________________
> MPlayer-dev-eng mailing list
> MPlayer-dev-eng at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-dev-eng

-- 
Best Regards,
        Atmos
____________________________________________
- MPlayer Developer - http://mplayerhq.hu/ -
____________________________________________