[MPlayer-dev-eng] MPlayer OpenGL patch

[Sven Goethel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

On Saturday 13 October 2001 13:09, Arpi wrote:
> Hi,
>
> > > > Can you fix the BGR rendering too? (it's broken after your patch)
> > >
> > > ok, i've fixed it.
> > >
> > > i had to remove that align 8 stuff, because it makes non-12*n wide
> > > movies broken.
> >
> > hmm .. really ?
> >
> > i have added alignment if images_width % 8 == 0 ..
>
> it's not ok.
> gl aligning is in byte, not in pixels.
> so it can be added if (images_width*images_bytespp)%8=0
> but what is the sense of setting aling if it's already aligned? :)
>

well .. true ;-)
sorry missed that.

the next patch tries to align on 8,4,2,1 ..

the alignment may gives a very little (?!) speed up
on some architectures ..

> > > > I'll apply patch then to CVS trunk.
> > >
> > > applied.
> >
> > well, now i have added opengl BGR support
> >
> > should work on opengl 1.2 capable cards ;-)
> >
> > so bgr speed should be now better
> > 	- opengl bgr display
> > 	- no more copy of the source image: "just use the source luke !" ;-)
>
> GL_BRG888 doesn't worked me, neither DRI or Utah-GLX (G400/G550)

thats pretty interesting ...

opengl 1.2 _must_ support this

i _have_ tested this on my r128 dri machine (direct & indirect rendering), 
and nvidia-glx machine - it works best for me.

for example, it works well in xmame.xgl also.

>
> > TODO:
> > 	- a better YUV integration (slice function)

done: only the "dirty" parts of the texture are being updated in memory,
'cause the memory update (glSub) takes most of the time.

> > 	- a better switching for gl features:
> > 		- filtering modes ..
		- antialiasing
is now done via the keys: 'a' (antialiasing, useless) and 'b' (bilinear)

> > 		- display movie in a real rendered tv ;-)
>
> ehh :)
		- you know, a useless rendered tv in 3d space,
		  where the movie is showing ;-)

so i am asking about hardware yuv2rgb ...
	- mmx
	- sse
	- Xv
	- opengl ? (never ever heard about yuv opengl support)

may be i have some rtfm stupid config errors, but i get this :
	Cannot init MMX colorspace transform
	No accelerated colorspace conversion found
??

>
> what about OSD support?
> using GL alphablending to render subtitles over the image?
>

yes and no ;-)

i have added OSD support, just using the exisiting "writing direct to texture/image"
functions - it works for me.

> A'rpi / Astral & ESP-team

because of the bigger diff i just send the complete vo_gl2.c as a bzip2 attachment.

CHANGES:
	speed:
		- using opengl BGR, instead of manual component flipping,
		  must work with opengl >= 1.2
		- alignment tweaks
		- texture internal format tweaks
		- update only the dirty-area of the texture 

	feature:
		- bilinear filtering on/off (key: 'b')
		- antialiasing on/off (key: 'a') (useless ?)
		- OSD support
		- fullscreen support

sven
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org

iD8DBQE7ykemHdOA30NoFAARAhYnAKCgOASu3HE+z1KP29UyQQbZOGqfQwCgkQak
gezdgIphYceCGwPnCmdhdEc=
=NCNG
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: vo_gl2.c.bz2
Type: application/x-bzip2
Size: 7700 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/attachments/20011015/c2a1cca7/attachment.bin>