[MPlayer-dev-eng] MPlayer OpenGL patch

[Arpi]

Hi,

> > >
> > > Can you fix the BGR rendering too? (it's broken after your patch)
> >
> > ok, i've fixed it.
> >
> > i had to remove that align 8 stuff, because it makes non-12*n wide
> > movies broken.
> 
> hmm .. really ?
> 
> i have added alignment if images_width % 8 == 0 ..

it's not ok.
gl aligning is in byte, not in pixels.
so it can be added if (images_width*images_bytespp)%8=0
but what is the sense of setting aling if it's already aligned? :)

> > > I'll apply patch then to CVS trunk.
> >
> > applied.
> >
> 
> well, now i have added opengl BGR support
> 
> should work on opengl 1.2 capable cards ;-)
> 
> so bgr speed should be now better
> 	- opengl bgr display
> 	- no more copy of the source image: "just use the source luke !" ;-)
GL_BRG888 doesn't worked me, neither DRI or Utah-GLX (G400/G550)

> TODO:
> 	- a better YUV integration (slice function)
> 	- a better switching for gl features:
> 		- filtering modes ..
> 		- display movie in a real rendered tv ;-)
ehh :)

what about OSD support?
using GL alphablending to render subtitles over the image?

> btw: i meant OSD: on screen display - should be supported in the future ..
:)


A'rpi / Astral & ESP-team

--
mailto:arpi at thot.banki.hu
http://esp-team.scene.hu