[Mplayer-dev-eng] some small patches

Christoph Lampert lampert at math.chalmers.se
Thu May 31 15:08:01 CEST 2001


>Hello mplayer developers.
>I turned -Wall on using yesterday's snapshot and made
>the changes in the attachment to make gcc happy.
>Continue the good work!
>With regards,
>Taco Witte


>demux_asf.c:209: warning: `time2' might be used uninitialized in this
>function

That because gcc doesn't understand that time2 is set and used only in 
case 0x08: of a switch, because there are two different switch statements. 

>stream.c: In function `stream_seek_long':
>stream.c:46: warning: `newpos' might be used uninitialized in this
>function

gcc is right, value of newpos is printed before it is set :-(

>if(verbose>=3){
>  printf("s->pos=%X  newpos=%X  new_bufpos=%X  buflen=%X  \n",
>    (unsigned int)s->pos,newpos,pos,s->buf_len);
>}


subreader.c: In function `sub_read_line_sami':
subreader.c:43: warning: `p' might be used uninitialized in this
function

Oops.. gcc might be right here as well...
>char *p;
>[...]
>*p++ = ' ';


This code (sub_read_line_sami()) has to be unused, otherwise it would
crash, or not?

gruel


-- 
Dipl. math. Christoph Lampert (complex analysis, integral formulae)
Email: gruel at gmx.de                |     Email: lampert at math.chalmers.se


_______________________________________________
Mplayer-dev-eng mailing list
Mplayer-dev-eng at lists.sourceforge.net
http://lists.sourceforge.net/lists/listinfo/mplayer-dev-eng



More information about the MPlayer-dev-eng mailing list