[MPlayer-dev-eng] Re: [Mplayer-cvslog] CVS: main/libmpdemux network.c,1.12,1.13 network.h,1.4,1.5

[Arpi]

Hi,

it wasn't a good step :(
we prefer having system includes at .c files.
including things from h files usually results things to be included thousand
times... :(

> Update of /cvsroot/mplayer/main/libmpdemux
> In directory mplayer:/var/tmp.root/cvs-serv6292
> 
> Modified Files:
> 	network.c network.h 
> Log Message:
> Moved the network related include files from network.c to network.h
> 
> 
> Index: network.c
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpdemux/network.c,v
> retrieving revision 1.12
> retrieving revision 1.13
> diff -u -r1.12 -r1.13
> --- network.c	7 Dec 2001 07:17:05 -0000	1.12
> +++ network.c	10 Dec 2001 01:34:08 -0000	1.13
> @@ -11,16 +11,6 @@
>  #include <string.h>
>  #include <unistd.h>
>  
> -#include <fcntl.h>
> -#include <netdb.h>
> -#include <netinet/in.h>
> -#include <sys/time.h>
> -#include <sys/types.h>
> -#include <sys/socket.h>
> -#include <arpa/inet.h>
> -
> -#include <pthread.h>
> -
>  #include <errno.h>
>  #include <ctype.h>
>  
> 
> Index: network.h
> ===================================================================
> RCS file: /cvsroot/mplayer/main/libmpdemux/network.h,v
> retrieving revision 1.4
> retrieving revision 1.5
> diff -u -r1.4 -r1.5
> --- network.h	20 Nov 2001 22:20:20 -0000	1.4
> +++ network.h	10 Dec 2001 01:34:08 -0000	1.5
> @@ -7,6 +7,14 @@
>  #ifndef __NETWORK_H
>  #define __NETWORK_H
>  
> +#include <fcntl.h>
> +#include <netdb.h>
> +#include <netinet/in.h>
> +#include <sys/time.h>
> +#include <sys/types.h>
> +#include <sys/socket.h>
> +#include <arpa/inet.h>
> +
>  #include "url.h"
>  
>  #define BUFFER_SIZE		2048
> 
> _______________________________________________
> Mplayer-cvslog mailing list
> Mplayer-cvslog at mplayerhq.hu
> http://mplayerhq.hu/mailman/listinfo/mplayer-cvslog
> 
> 


A'rpi / Astral & ESP-team

--
mailto:arpi at thot.banki.hu
http://esp-team.scene.hu