[MPlayer-cygwin] Win32 gui updates
Diego Biurrun
diego at biurrun.de
Thu Mar 16 02:10:14 CET 2006
On Wed, Mar 15, 2006 at 05:54:13PM -0500, Erik Lunchpail wrote:
> > OK, I just had a five minutes look at it, it's big. I can only give
> > some cosmetical suggestions right now. Please remove all trailing
> > whitespace from the patch and indent with spaces, you have tabs in a
> > few
> > spots. Also, some lines in your files are excessively long, try to
> > break them to 80 characters somehow.
>
> Trailing whitespace removed thx to :%s/\s\+$// and mixed tabs should be
> gone. It's not 80 characters, but it should bet a lot better (only a
> couple lines wrap at 1024x768).
Yes, better, but there is still some room for improvement ;)
Also, you still have some cosmetics in mplayer.c:
-#endif
+#endif
I suggest you to propose this on dev-eng.
Diego
More information about the MPlayer-cygwin
mailing list