[MPlayer-cygwin] win32 GUI

[Diego Biurrun]

Joseph Miller writes:
> Ok, I've got the patches here from the CVS that I downloaded for the win32 gui 
> that I made, and I also have a tar archive which contains another folder 
> which will need to be added to the source before compilation.

OK, nice, I can get this compiled and everything after tweaking
config.mak, but how do I run the GUI.  Sorry, I am currently too lazy
to read the code more thoroughly..

> I have made a 
> lot of effort to comply with the requirements for submitting patches what 
> with all the string error checking, code formatting, etc.  The only thing 
> that I have not done is converted by debugging messages to mp_msg(), but  
> these are disabled by default and only compile on --enable-gui32-debugging.  

You should convert this to mp_msg eventually.

> I will be constantly updating this GUI because a project at my job requires a 
> custom media player (e.g. I have both the time and the fundage necessary to 
> work on this project) so please contact me if you have any comments, 
> questions, suggestions, or criticisms.

:-)

>  mplayer.exe.so:	$(MPLAYER_DEP) mplayer.exe.spec.c
> -	$(CC) $(CFLAGS) -Wall -shared  -Wl,-rpath,/usr/local/lib -Wl,-Bsymbolic  -o mplayer.exe.so $(OBJS_MPLAYER) mplayer.exe.spec.c libvo/libvo.a libao2/libao2.a $(MENU_LIBS) $(VIDIX_LIBS) $(GUI_LIBS) $(COMMON_LIBS) $(GTK_LIBS) $(VO_LIBS) $(AO_LIBS) $(EXTRA_LIB) $(LIRC_LIB) $(LIRCC_LIB) $(STATIC_LIB) $(ARCH_LIB) -lwine -lm 
> +	$(CC) $(CFLAGS) -Wall -shared  -Wl,-rpath,/usr/local/lib -Wl,-Bsymbolic  -o mplayer.exe.so $(OBJS_MPLAYER) mplayer.exe.spec.c libvo/libvo.a libao2/libao2.a $(MENU_LIBS) $(VIDIX_LIBS) $(GUI_LIBS) $(COMMON_LIBS) $(GTK_LIBS) $(VO_LIBS) $(AO_LIBS) $(EXTRA_LIB) $(LIRC_LIB) $(LIRCC_LIB) $(STATIC_LIB) $(ARCH_LIB) -lwine -lm
>  
>  $(PRG_MENCODER): $(MENCODER_DEP)
> -	$(CC) $(CFLAGS) -o $(PRG_MENCODER) $(OBJS_MENCODER) libmpcodecs/libmpencoders.a $(ENCORE_LIB) $(COMMON_LIBS) $(EXTRA_LIB) $(MLIB_LIB) $(LIRC_LIB) $(LIRCC_LIB) $(ARCH_LIB) $(I18NLIBS) -lm 
> +	$(CC) $(CFLAGS) -o $(PRG_MENCODER) $(OBJS_MENCODER) libmpcodecs/libmpencoders.a $(ENCORE_LIB) $(COMMON_LIBS) $(EXTRA_LIB) $(MLIB_LIB) $(LIRC_LIB) $(LIRCC_LIB) $(ARCH_LIB) $(I18NLIBS) -lm
>  endif

These are whitespace only changes, don't do this.

> --- ../main/osdep/mplayer.rc	2004-06-28 12:34:24.000000000 -0400
> +++ osdep/mplayer.rc	2004-09-10 10:18:54.953125000 -0400
> @@ -1,4 +1,4 @@
> -/*Windows resource file for MPlayer 
> +/*Windows resource file for MPlayer
>  {
> -    BLOCK "StringFileInfo" 
> +    BLOCK "StringFileInfo"

same here

> +#include "../ttplayer/ttplayer.rc"
> \ No newline at end of file

Try to avoid missing newlines, it just creates warnings.

Diego