[MPlayer-cvslog] r32724 - trunk/configure
Reimar.Doeffinger at gmx.de
Wed Dec 22 17:37:13 CET 2010
On 22 dec 2010, at 12:47, Diego Biurrun <diego at biurrun.de> wrote:
> On Sun, Dec 19, 2010 at 11:02:53PM +0100, reimar wrote:
>> Compilation fixes for currentl Cygwin.
>> --- trunk/configure Sun Dec 19 15:19:04 2010 (r32723)
>> +++ trunk/configure Sun Dec 19 23:02:52 2010 (r32724)
>> @@ -1519,6 +1519,12 @@ if win32 ; then
>> +if cygwin ; then
>> + # e.g. priority.c needs _WIN32 define, but
>> + # latest cygwin no longer defines it
>> + extra_cflags="-D_WIN32 $extra_cflags"
> Do we need the _WIN32 #define at all? Some other places assume that
> Cygwin behaves different from _WIN32, for example
> ./configure:#if !defined(_WIN32) || defined(__CYGWIN__)
> ./vidix/pci.c:#elif defined (_WIN32) || defined(__CYGWIN__)
> It seems to me we should rather fix priority.c.
If the fix means adding a extra check for the cygwin define: no, it's not my goal to add useless code.
Also it would be inconsistent, win32 in configure is both mingw and cygwin.
More information about the MPlayer-cvslog