[MPlayer-cvslog] r32724 - trunk/configure

Diego Biurrun diego at biurrun.de
Wed Dec 22 12:47:11 CET 2010


On Sun, Dec 19, 2010 at 11:02:53PM +0100, reimar wrote:
> 
> Log:
> Compilation fixes for currentl Cygwin.
> 
> --- trunk/configure	Sun Dec 19 15:19:04 2010	(r32723)
> +++ trunk/configure	Sun Dec 19 23:02:52 2010	(r32724)
> @@ -1519,6 +1519,12 @@ if win32 ; then
>  
> +if cygwin ; then
> +  # e.g. priority.c needs _WIN32 define, but
> +  # latest cygwin no longer defines it
> +  extra_cflags="-D_WIN32 $extra_cflags"
> +fi

Do we need the _WIN32 #define at all?  Some other places assume that
Cygwin behaves different from _WIN32, for example

./configure:#if !defined(_WIN32) || defined(__CYGWIN__)
./vidix/pci.c:#elif defined (_WIN32) || defined(__CYGWIN__)

It seems to me we should rather fix priority.c.

> @@ -6622,7 +6628,10 @@ echores "$_faac"
>  
>  echocheck "FAAD2 support"
>  if test "$_faad_internal" = auto ; then
> -  if x86_32 && test cc_vendor=gnu; then
> +  if cygwin ; then
> +    _faad_internal=no
> +    res_comment="does not compile on cygwin"
> +  elif x86_32 && test cc_vendor=gnu; then

This reminds me that we should look into removing internal libfaad2.

Diego


More information about the MPlayer-cvslog mailing list