[MPlayer-cvslog] r29290 - trunk/xvid_vbr.c

[Uoti Urpala]

On Tue, 2009-05-12 at 14:36 -0400, Reynaldo H. Verdejo Pinochet wrote:
> Uoti Urpala wrote:
> > If you're doing useful work on a file and are bothered by trailing
> > whitespace then it could be OK to remove it as part of other changes.
> > But removing trailing whitespace from one random file for no special
> > reason is not normally worth a commit.
> 
> - From what I know trailing white space is something we don't want

It's not wanted, but we don't want unnecessary commits either. "Fixing"
trailing whitespace in one random file is usually not worth one extra
commit.

> and mixed cosmetic/functional commits are frowned upon so you
> are basically saying there is no way of doing this properly.

I didn't mean that you'd remove many instances of trailing whitespace in
the same commit that does functional changes. I meant that doing a
separate commit for that (or preferably a combined commit of all
"uninteresting" changes if others exist) can be OK _if_ you're doing
some significant real work on the file.

> Anyway, I already said I'm taking the advice and while I
> keep thinking in the terms I previously explained I'm not
> planing to convince a single soul on the color of this
> bikeshed.

IMO this is not a "bikeshed" issue. Spamming commits like you did is
actually harmful practice, and should be discouraged.