[MPlayer-cvslog] r29263 - trunk/configure

[Diego Biurrun]

On Tue, May 05, 2009 at 09:14:04PM +0300, Uoti Urpala wrote:
> On Tue, 2009-05-05 at 20:07 +0200, Diego Biurrun wrote:
> > On Tue, May 05, 2009 at 08:57:47PM +0300, Uoti Urpala wrote:
> > > On Tue, 2009-05-05 at 19:30 +0200, diego wrote:
> > > > Add #define for HAVE_DVDCSS_DVDCSS_H to config.h instead of passing it on the
> > > > compiler command line, like we do for most other preprocessor definitions.
> > > 
> > > At least this commit message is wrong, as that macro name doesn't even
> > > appear in MPlayer's own codebase outside configure, and so it is clearly
> > > not comparable to "most other preprocessor definitions". Is there a
> > > valid reason why this would be correct? If so, that should be in the
> > > commit message.
> > 
> > Commit message updated.
> 
> This still doesn't have the important information: that _libdvdread
> changed_, and that is why it can now be done this way. It's obvious that
> passing the information in a header is better than adding it to the
> compiler command line, and explaining that is mostly pointless; what's
> not obvious is why it was not done this way before, and what has changed
> now.

Hopefully fixed now.  Thanks for keeping me honest :)

Diego