[MPlayer-cvslog] r29263 - trunk/configure

[Uoti Urpala]

On Tue, 2009-05-05 at 20:57 +0300, Uoti Urpala wrote:
> On Tue, 2009-05-05 at 19:30 +0200, diego wrote:
> > Add #define for HAVE_DVDCSS_DVDCSS_H to config.h instead of passing it on the
> > compiler command line, like we do for most other preprocessor definitions.
> 
> At least this commit message is wrong, as that macro name doesn't even
> appear in MPlayer's own codebase outside configure, and so it is clearly
> not comparable to "most other preprocessor definitions". Is there a
> valid reason why this would be correct? If so, that should be in the
> commit message. If not, did you do anything at all to verify what you

I checked dvdread and you had added a config.h include there. So it's
just the commit message that's wrong. Obviously the reason for moving it
to config.h was not that "other definitions are there" - that's always
been the case and nobody would have placed it elsewhere without a
reason. Instead it now _can_ be moved because of a libdvdread change.