[MPlayer-cvslog] r27849 - trunk/libvo/x11_common.c

[Reimar Döffinger]

On Thu, Oct 30, 2008 at 08:35:58PM +0200, Uoti Urpala wrote:
> On Thu, 2008-10-30 at 18:46 +0100, Reimar Döffinger wrote:
> > On Wed, Oct 29, 2008 at 11:03:39PM +0100, ben wrote:
> > > Log:
> > > Remove X11 backing store: this is now a useless flag.
> 
> > > Patch by Stephane Marchesin (marchesin at icps dot u dash strasbg dot fr).
> > > 
> > > For more info, see long flame thread at:
> > > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2008-August/058323.html
> > 
> > Well, and still nobody has clearly explained the why?!
> > So, why did you commit it? Just because a patch was sent?
> > Or to work around buggy/slow/stupid video drivers? Or why?
> 
> Enabling backing store is apparently harmful in xserver 1.5.
> See http://www.nvnews.net/vbulletin/showthread.php?t=119047 (I already
> posted that link when it was discussed before).
> 
> I didn't see any mention of backing store being useful in the earlier
> mplayer-dev-eng thread. The above link says it's harmful in some xserver
> versions. Given that, turning backing store off seems reasonable to me.
> Even working around buggy drivers would be an OK reason if there's no
> clearly explained rationale why it would should remain on (switching it
> off seems unlikely to trigger any new bugs).

Oh, I do not disagree, but this was never discussed as "workaround for
X.org 1.5 performance issue".
I'd probably agree that it is worth it, but now even the commit message
says the reason is it is "useless" which seen even in the most positive
light only means there is no reason to keep it but is not a reason to
remove it, which a commit message certainly should contain.
Thus my question, which is the actual why and why was that reason
considered more important than the performance improvement that probably
could be possible with a well-implemented X-server (note this file is called
x11_common.c, not xorg_specific_x11_common.c)?