[MPlayer-cvslog] r27849 - trunk/libvo/x11_common.c

[Uoti Urpala]

On Thu, 2008-10-30 at 18:46 +0100, Reimar Döffinger wrote:
> On Wed, Oct 29, 2008 at 11:03:39PM +0100, ben wrote:
> > Log:
> > Remove X11 backing store: this is now a useless flag.

> > Patch by Stephane Marchesin (marchesin at icps dot u dash strasbg dot fr).
> > 
> > For more info, see long flame thread at:
> > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2008-August/058323.html
> 
> Well, and still nobody has clearly explained the why?!
> So, why did you commit it? Just because a patch was sent?
> Or to work around buggy/slow/stupid video drivers? Or why?

Enabling backing store is apparently harmful in xserver 1.5.
See http://www.nvnews.net/vbulletin/showthread.php?t=119047 (I already
posted that link when it was discussed before).

I didn't see any mention of backing store being useful in the earlier
mplayer-dev-eng thread. The above link says it's harmful in some xserver
versions. Given that, turning backing store off seems reasonable to me.
Even working around buggy drivers would be an OK reason if there's no
clearly explained rationale why it would should remain on (switching it
off seems unlikely to trigger any new bugs).