[MPlayer-cvslog] r27822 - trunk/libmpcodecs/vf_palette.c

[Diego Biurrun]

On Mon, Oct 27, 2008 at 09:16:02PM +0100, Michael Niedermayer wrote:
> On Mon, Oct 27, 2008 at 07:22:45PM +0100, Diego Biurrun wrote:
> [...]
> > > > Feel free to test the functionality of the filter as much as you like.
> > > > My actions were still better than those of any developer who left
> > > > compilation broken, which includes you. So your flaming is misguided.
> > > 
> > > Sorry but i was not aware of the swscale change breaking compilation
> > > before i saw your commit. Had you attempted to contact me or waited until
> > > ive read mplayer-dev i would have fixed it properly.
> > 
> > Well, maybe you can tell us if this filter still makes any sense or
> > should just be removed.
> 
> I think that vf_scale should be able to handle things fine and palette
> probably is redundant. vf scale might need a PAL pix fmt added to a list
> though ...
> but i did not test this at all, if someone does test it and it works then
> i certainly support droping vf_palette
 
Can you suggest a proper test method?

> > If you want to fix things properly, there is a patch for vf_smartblur on
> > dev-eng.  It's one of your filters and it is currently broken.
> 
> patch reviewed, though i must say you complain quick, the patch was sent
> a few hours ago

I did not mean to complain, just point out the patch.  Maybe my choice
of words was not ideal...

Diego