[MPlayer-cvslog] r27822 - trunk/libmpcodecs/vf_palette.c

[Michael Niedermayer]

On Mon, Oct 27, 2008 at 10:03:41PM +0100, Diego Biurrun wrote:
> On Mon, Oct 27, 2008 at 09:16:02PM +0100, Michael Niedermayer wrote:
> > On Mon, Oct 27, 2008 at 07:22:45PM +0100, Diego Biurrun wrote:
> > [...]
> > > > > Feel free to test the functionality of the filter as much as you like.
> > > > > My actions were still better than those of any developer who left
> > > > > compilation broken, which includes you. So your flaming is misguided.
> > > > 
> > > > Sorry but i was not aware of the swscale change breaking compilation
> > > > before i saw your commit. Had you attempted to contact me or waited until
> > > > ive read mplayer-dev i would have fixed it properly.
> > > 
> > > Well, maybe you can tell us if this filter still makes any sense or
> > > should just be removed.
> > 
> > I think that vf_scale should be able to handle things fine and palette
> > probably is redundant. vf scale might need a PAL pix fmt added to a list
> > though ...
> > but i did not test this at all, if someone does test it and it works then
> > i certainly support droping vf_palette
>  
> Can you suggest a proper test method?

remove vf_palette locally, and try to play a paletted video. with a vo that 
supports bgr/rgb32/24. force the format with format=.
if you dont have a vo that supports all 4 you can use vf scale to work around
that

if any of these look worse than with vf palette then theres a problem if not
vf palette can be droped.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20081028/3a7a6712/attachment.pgp>