[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Michael Niedermayer]

On Thu, Jun 05, 2008 at 10:28:34AM +0200, Diego Biurrun wrote:
> On Wed, Jun 04, 2008 at 09:29:19PM +0200, Michael Niedermayer wrote:
> > On Wed, Jun 04, 2008 at 05:34:13PM +0200, Luca Barbato wrote:
> > > Reimar Döffinger wrote:
> > > > On Sat, Apr 12, 2008 at 05:51:08PM +0200, uau wrote:
> > > >>
> > > >> Log:
> > > >> Reindent demuxer.c
> > > > 
> > > > This is not only a reindentation,
> > > 
> > > It is, at least if you consider reindent as "do what indent does"
> > 
> > ----------------------------------------
> > These remove comments, remove outcommented code, ...
> > this definitly is not what indent does and its just what i quickly spotted
> 
> We've been over this before.  The commit message was bad, it has been
> fixed.  You can hardly accuse Uoti of writing bad commit messages in
> general.

The commit was bad and i suspect that was because uoti did not review what
he commited before he commited it.
Otherwise why would he have missed that it was not just a reindentation?


> 
> > And thats why such commits are so bad and why we all complain, they are a
> > nightmare to review, you missed the things above, others missed them too.
> 
> I posted a diff without whitespace changes to this thread.  It was not
> at all hard to review.  Move on, nothing to see here...

you posted a >40k diff -uwbBE
This diff was still 90% whitespace changes and very hard to review, the
mere size showed that.
I did manually look over it and posted the hunks which where not whitespace
changes.


> 
> > Besides demuxer.c is not maintained by uoti ...
> 
> Other files were reindented without a big outcry before.

* which files where reindented without spoken or unspoken approval of the
  maintainer?
* demuxer.c was NOT just reindented, comments and outcommented code was
  removed as well.


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The greatest way to live with honor in this world is to be what we pretend
to be. -- Socrates
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20080605/03e6210e/attachment.pgp>