[MPlayer-cvslog] r26411 - trunk/libmpdemux/demuxer.c

[Diego Biurrun]

On Thu, Jun 05, 2008 at 12:46:01PM +0200, Dominik 'Rathann' Mierzejewski wrote:
> On Thursday, 05 June 2008 at 10:28, Diego Biurrun wrote:
> > On Wed, Jun 04, 2008 at 09:29:19PM +0200, Michael Niedermayer wrote:
> > > Besides demuxer.c is not maintained by uoti ...
> > 
> > Other files were reindented without a big outcry before.
> 
> That doesn't make it right. He should've asked in the mailing list
> first. Isn't it standard procedure? Post a patch, ask for objections
> and threaten to commit in X days if there aren't any. It's not too
> much to ask IMHO.

It was not done maliciously, so no need to get worked up over things.
There were precedents which did not cause trouble, so no trouble was to
be expected in this case.  Sending patches gives extra assurance, but I
can understand that it is burdensome when you are carrying around a lot
of changes.  I have the same problem myself.

I don't even mind commits getting (civilly) criticized, even reverted.
There's just no need to hack somebody's hand off for such things.
Revert, split, change, transmogrify the commit, move on.

That said, I welcome each file that gets reindented.

> Besides, what happened to your promise to revert and fix all Uoti's
> bad commits?

I split the demux_mkv thing, I removed unnecessary parentheses from all
files that are not imported libraries.  I can go ahead and remove the
commented out stuff and reindent the file as well, sure.

Diego