[MPlayer-cvslog] r27240 - trunk/configure

[Diego Biurrun]

On Tue, Jul 15, 2008 at 01:04:16AM +0200, Michael Niedermayer wrote:
> On Tue, Jul 15, 2008 at 12:50:09AM +0200, Diego Biurrun wrote:
> > On Mon, Jul 14, 2008 at 10:14:00PM +0200, Michael Niedermayer wrote:
> > > Do we want all that _GNU_SOURCE enables ?
> > > Do we want mplayer to require and depend on all that _GNU_SOURCE enables ?
> > > no?
> > 
> > -std=gnu99 does not enable _GNU_SOURCE, please check your facts before
> > making such claims.
> 
> I did not claim that.

You said:

Do we want all that _GNU_SOURCE enables ?                                                                                                                                             
Do we want mplayer to require and depend on all that _GNU_SOURCE enables ?                                                                                                            
no?

With a lengthy quote about _GNU_SOURCE above.  If you did not try to
claim that -std=gnu99 enables _GNU_SOURCE, then I have no idea what you
were trying to say.

> Though i wonder how you checked that your claim of
> "-std=gnu99 does not enable _GNU_SOURCE"
> is true?

Trivially easy:

cat << EOF > foo.c
#ifdef _GNU_SOURCE
#error "_GNU_SOURCE enabled"
#else
#error "_GNU_SOURCE disabled"
#endif
EOF

silver:/tmp $ gcc -std=gnu89 foo.c 
foo.c:4:2: error: #error "_GNU_SOURCE disabled"
silver:/tmp $ gcc -std=gnu99 foo.c 
foo.c:4:2: error: #error "_GNU_SOURCE disabled"
silver:/tmp $ gcc -std=c99 foo.c 
foo.c:4:2: error: #error "_GNU_SOURCE disabled"

> Besides what does gnu99 enable on the compiler you tested?

See what I posted in another mail.

Diego