[MPlayer-cvslog] r27240 - trunk/configure

[Michael Niedermayer]

On Tue, Jul 15, 2008 at 09:21:05AM +0200, Diego Biurrun wrote:
> On Tue, Jul 15, 2008 at 01:04:16AM +0200, Michael Niedermayer wrote:
> > On Tue, Jul 15, 2008 at 12:50:09AM +0200, Diego Biurrun wrote:
> > > On Mon, Jul 14, 2008 at 10:14:00PM +0200, Michael Niedermayer wrote:
> > > > Do we want all that _GNU_SOURCE enables ?
> > > > Do we want mplayer to require and depend on all that _GNU_SOURCE enables ?
> > > > no?
> > > 
> > > -std=gnu99 does not enable _GNU_SOURCE, please check your facts before
> > > making such claims.
> > 
> > I did not claim that.
> 
> You said:
> 
> Do we want all that _GNU_SOURCE enables ?                                                                                                                                             
> Do we want mplayer to require and depend on all that _GNU_SOURCE enables ?                                                                                                            
> no?
> 
> With a lengthy quote about _GNU_SOURCE above.  If you did not try to
> claim that -std=gnu99 enables _GNU_SOURCE, then I have no idea what you
> were trying to say.

I was trying to say that gnu99 will likely enable _GNU_SOURCE sooner or later.
And that if you dont want that you better dont use undefined language options
that start with gnu.
gnu99 does not seem to enable _GNU_SOURCE currently on current gcc, this does
not mean it wont in the future. Its a rather logic next step for the gcc
devels to enable _GNU_SOURCE with gnu99.
Its not as if gcc is or ever was a compiler warning about non standard
extension usage or that required elaborate options to be specified for
there use. Portability to non gnu systems is not in the interrest of the
gnu developers.


> 
> > Though i wonder how you checked that your claim of
> > "-std=gnu99 does not enable _GNU_SOURCE"
> > is true?
> 
> Trivially easy:
> 
> cat << EOF > foo.c
> #ifdef _GNU_SOURCE
> #error "_GNU_SOURCE enabled"
> #else
> #error "_GNU_SOURCE disabled"
> #endif
> EOF
> 
> silver:/tmp $ gcc -std=gnu89 foo.c 
> foo.c:4:2: error: #error "_GNU_SOURCE disabled"
> silver:/tmp $ gcc -std=gnu99 foo.c 
> foo.c:4:2: error: #error "_GNU_SOURCE disabled"
> silver:/tmp $ gcc -std=c99 foo.c 
> foo.c:4:2: error: #error "_GNU_SOURCE disabled"

This test is flawed, you should try to use a function that is available
only under _GNU_SOURCE. I dont dispute that the result will be the same
but what you tested is rather different from what we care about.


> 
> > Besides what does gnu99 enable on the compiler you tested?
> 
> See what I posted in another mail.

And see my awnser to your mail

Or just explain us why i need 
-fasm -fms-extensions -D_BSD_SOURCE -D_POSIX_C_SOURCE=200112L
for --std=c99 but not for --std=gnu99
These where not amongth your list still its clear gnu99 must have enabled
them.
What else is missing from your list?

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Republics decline into democracies and democracies degenerate into
despotisms. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/mplayer-cvslog/attachments/20080715/73eed178/attachment.pgp>