[MPlayer-cvslog] r25843 - trunk/command.c

[Reimar Döffinger]

Hello,
On Thu, Jan 24, 2008 at 09:55:11AM +0100, Benjamin Zores wrote:
> > I think I missed why the ass_enabled check is supposed to make sense.
> > And I certainly don't see why you changed your original patch in a way
> > that doubles the number of #ifdefs!
> 
> Would it make sense to updated both text_font and ass_font scaler at
> the same time ?
> I still don't see how both can be used at the same time.
> But if they can, I have no problem updating this to handle both (but
> not until tonight).

Well, the sense I can see in it that it about halves the amount of code.
So you are asking the completely wrong question, the right one is: is
there a reason to have an additional check in the code?
If not, please get rid of the clutter.

Greetings,
Reimar Döffinger