[MPlayer-cvslog] r25843 - trunk/command.c

Benjamin Zores ben at geexbox.org
Thu Jan 24 09:55:11 CET 2008


On Jan 24, 2008 9:51 AM, Reimar Döffinger
<Reimar.Doeffinger at stud.uni-karlsruhe.de> wrote:
> Hello,
> On Wed, Jan 23, 2008 at 11:33:46PM +0100, ben wrote:
> > Modified: trunk/command.c
> > ==============================================================================
> > --- trunk/command.c   (original)
> > +++ trunk/command.c   Wed Jan 23 23:33:46 2008
> > @@ -1796,17 +1796,44 @@ static int mp_property_sub_scale(m_optio
> >              if (!arg)
> >                  return M_PROPERTY_ERROR;
> >              M_PROPERTY_CLAMP(prop, *(float *) arg);
> > +#ifdef USE_ASS
> > +            if (ass_enabled) {
> > +                ass_font_scale = *(float *) arg;
> > +                ass_force_reload = 1;
> > +            }
> > +            else {
> > +#endif
> >              text_font_scale_factor = *(float *) arg;
> >              force_load_font = 1;
> > +#ifdef USE_ASS
> > +            }
> > +#endif
>
> I think I missed why the ass_enabled check is supposed to make sense.
> And I certainly don't see why you changed your original patch in a way
> that doubles the number of #ifdefs!

Would it make sense to updated both text_font and ass_font scaler at
the same time ?
I still don't see how both can be used at the same time.
But if they can, I have no problem updating this to handle both (but
not until tonight).

Ben

-- 
"My life, and by extension everyone else's is meaningless."
Bender, Futurama


More information about the MPlayer-cvslog mailing list