[MPlayer-cvslog] r24798 - in trunk: libmpcodecs/ve_vfw.c loader/win32.c loader/wine/objbase.h

[Compn]

On Wed, 17 Oct 2007 15:06:40 +0200, Diego Biurrun wrote:

>On Wed, Oct 17, 2007 at 07:14:21AM +0200, compn wrote:
>> 
>> Log:
>> vfw fixes
>> patch by Gianluigi Tiesi mplayer___netfarm.it
>> http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/054136.html
>
>You have merged two separate patches into one.  This is unacceptable,
>revert this commit.


[21:41] <Sherpya> Compn: 24798 commit is unsplittable


>Also, the commit message is bad, ask the patch submitter for a better
>one if you cannot come up with one yourself.

done

>
>> --- (empty file)
>> +++ trunk/loader/wine/objbase.h	Wed Oct 17 07:14:21 2007
>> @@ -0,0 +1,19 @@
>> +#ifndef WINE_OBJBASE_H
>> +#define WINE_OBJBASE_H
>> + [...]
>> +#endif
>
>Please add a comment to the #endif.

will do if its ok not to revert etc

-compn