[MPlayer-cvslog] r24798 - in trunk: libmpcodecs/ve_vfw.c loader/win32.c loader/wine/objbase.h

[Uoti Urpala]

On Wed, 2007-10-17 at 15:06 +0200, Diego Biurrun wrote:
> On Wed, Oct 17, 2007 at 07:14:21AM +0200, compn wrote:
> > Log:
> > vfw fixes
> > patch by Gianluigi Tiesi mplayer___netfarm.it
> > http://lists.mplayerhq.hu/pipermail/mplayer-dev-eng/2007-September/054136.html
> 
> You have merged two separate patches into one.  This is unacceptable,
> revert this commit.

While the patches do seem independent and committing them separately
would have been better I think adding a revert and recommits to the
history would be worse. They touch completely different files so you can
explain what they do by changing the commit message.

> Also, the commit message is bad, ask the patch submitter for a better
> one if you cannot come up with one yourself.

This is a far worse problem IMO. It's not obvious with a quick read what
these changes are supposed to do.

I think the commit should not be reverted, but the commit message should
be changed to explain that there are in fact two separate changes (and
which changed files contain which) and what those changes actually do.