[MPlayer-cvslog] r25065 - trunk/stream/stream_dvd.c

[Ivo]

Hi,

On Monday 19 November 2007 08:29, Reimar Döffinger wrote:
> Hello,
> On Mon, Nov 19, 2007 at 12:01:00AM +0100, Ivo wrote:
> [...]
>
> > Anyway, why not use byteswap.h instead of the inline functions in
> > bswap.h if it's available? That's what ffmpeg does. It (un)defines
> > HAVE_BYTESWAP_H during configure. Why is that a mess?
>
> Because HAVE_BYTESWAP_H is to get better performance and you want to
> misuse it as a bug fix for your system headers.
> That does not make it wrong in itself, but you want to use it for
> completely wrong reasons, and there is no guarantee that this workaround
> will continue to work in the future (e.g. we might decide to not use
> byteswap.h on x86 because it is IMO unlikely to contain functions that
> are faster than ours but might be broken...

Sorry for not responding earlier. Yes, I agree it's not a proper workaround. 
So, I will move the include up a bit as you suggested. I guess there are 
distributions of about 1 year old that use the same kernel version and 
system headers as I do.

--Ivo