[MPlayer-cvslog] r25065 - trunk/stream/stream_dvd.c

[Reimar Döffinger]

Hello,
On Mon, Nov 19, 2007 at 12:01:00AM +0100, Ivo wrote:
[...]
> Anyway, why not use byteswap.h instead of the inline functions in bswap.h if 
> it's available? That's what ffmpeg does. It (un)defines HAVE_BYTESWAP_H 
> during configure. Why is that a mess?

Because HAVE_BYTESWAP_H is to get better performance and you want to
misuse it as a bug fix for your system headers.
That does not make it wrong in itself, but you want to use it for
completely wrong reasons, and there is no guarantee that this workaround
will continue to work in the future (e.g. we might decide to not use
byteswap.h on x86 because it is IMO unlikely to contain functions that
are faster than ours but might be broken...

Greetings,
Reimar Döffinger