[MPlayer-cvslog] r23185 - in trunk/vidix: cyberblade_vid.c mach64_vid.c mga_vid.c pm3_vid.c radeon_vid.c

[The Wanderer]

Reimar Döffinger wrote:

> Hello,
> On Tue, May 01, 2007 at 02:27:54PM +0200, Diego Biurrun wrote:
> 
>> On Tue, May 01, 2007 at 12:14:29AM +0200, ben wrote:
>> 
>>> Log:
>>> synced with upstream vidix, prevented some drivers to work on some configs/archs
>> 
>> May I suggest using present tense in commit log messages?  This one
>> is highly confusing.
> 
> How would "syncs with upstream vidix, prevents some drivers to work
> on some configs/archs" be any better?

I thought the suggestion was for "sync" and "prevent" - although that
still leaves it unclear as to whether this change prevents the drivers
from working, or the lack of this change prevented them from working.
"sync" and e.g. "makes" (and dropping the "to") would probably be
better.

-- 
       The Wanderer

Warning: Simply because I argue an issue does not mean I agree with any
side of it.

Secrecy is the beginning of tyranny.