[MPlayer-cvslog] r23185 - in trunk/vidix: cyberblade_vid.c mach64_vid.c mga_vid.c pm3_vid.c radeon_vid.c

[Diego Biurrun]

On Tue, May 01, 2007 at 02:51:21PM +0200, Reimar Döffinger wrote:
> On Tue, May 01, 2007 at 02:27:54PM +0200, Diego Biurrun wrote:
> > On Tue, May 01, 2007 at 12:14:29AM +0200, ben wrote:
> > > Log:
> > > synced with upstream vidix, prevented some drivers to work on some configs/archs
> > 
> > May I suggest using present tense in commit log messages?  This one is
> > highly confusing.
> 
> How would "syncs with upstream vidix, prevents some drivers to work on
> some configs/archs" be any better?

A confusing complaint about a confusing log message..  Ironic, isn't it?

> I think the missing subjects to "prevented" is actually what makes it confusing
> (or more precisely, impossible to understand), even more so as one might
> assume it to refer to the "synced" part (since that's the only other
> thing there), which gives the completely wrong meaning of "synced with
> upstream to prevent some drivers to work"...

Agreed.  The log message needs to be changed in any case.

Diego