[MPlayer-cvslog] r22091 - trunk/configure

Diego Biurrun diego at biurrun.de
Wed Jan 31 17:43:40 CET 2007


On Wed, Jan 31, 2007 at 03:56:39PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 31 January 2007 at 15:42, Diego Biurrun wrote:
> > On Wed, Jan 31, 2007 at 03:31:52PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > > On Wednesday, 31 January 2007 at 10:25, lorenm wrote:
> > > > 
> > > > Log:
> > > > libfaac detection skipped linking, and thus only checked for headers and not libs
> > > > 
> > > > --- trunk/configure	(original)
> > > > +++ trunk/configure	Wed Jan 31 10:25:05 2007
> > > > @@ -5863,7 +5863,7 @@
> > > >  EOF
> > > >    _faac=no
> > > >    for _ld_faac in "-lfaac" "-lfaac -lmp4v2 -lstdc++" ; do
> > > > -    cc_check -c -O4 $_ld_tmp $_ld_lm && _libs_mencoder="$_libs_mencoder $_ld_faac" && _faac=yes && break
> > > > +    cc_check -O4 $_ld_tmp $_ld_lm && _libs_mencoder="$_libs_mencoder $_ld_faac" && _faac=yes && break
> > > 
> > > Can we drop the "-O4" from test while we're at it?
> > 
> > Why?  And why is it there in the first place?
> 
> Because it crashed on some GCC 3.x flavour while it worked with -O2 (which
> I specified in CFLAGS). IOW: I don't like configure overriding my CFLAGS choice.

Feel free to change it ...

Diego




More information about the MPlayer-cvslog mailing list