[MPlayer-cvslog] r22091 - trunk/configure

[Reimar Döffinger]

Hello,
On Wed, Jan 31, 2007 at 03:56:39PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> On Wednesday, 31 January 2007 at 15:42, Diego Biurrun wrote:
> > On Wed, Jan 31, 2007 at 03:31:52PM +0100, Dominik 'Rathann' Mierzejewski wrote:
> > > On Wednesday, 31 January 2007 at 10:25, lorenm wrote:
[...]
> > > > -    cc_check -c -O4 $_ld_tmp $_ld_lm && _libs_mencoder="$_libs_mencoder $_ld_faac" && _faac=yes && break
> > > > +    cc_check -O4 $_ld_tmp $_ld_lm && _libs_mencoder="$_libs_mencoder $_ld_faac" && _faac=yes && break
> > > 
> > > Can we drop the "-O4" from test while we're at it?

I'd agree with that.

> > Why?  And why is it there in the first place?
> 
> Because it crashed on some GCC 3.x flavour while it worked with -O2 (which
> I specified in CFLAGS). IOW: I don't like configure overriding my CFLAGS choice.

Well, that is more an argument to keep it. Anything that causes people
running away screaming from broken compilers instead of producing broken
code is good...

Greetings,
Reimar Döffinger