[MPlayer-cvslog] r22237 - trunk/libmpcodecs/vf_scale.c

[Diego Biurrun]

On Sat, Feb 17, 2007 at 02:10:25PM +0100, Diego Biurrun wrote:
> On Sat, Feb 17, 2007 at 01:35:15PM +0100, Michael Niedermayer wrote:
> > 
> > On Sat, Feb 17, 2007 at 01:20:31PM +0100, Michael Niedermayer wrote:
> > > 
> > > On Sat, Feb 17, 2007 at 12:48:24PM +0100, Diego Biurrun wrote:
> > > > On Sat, Feb 17, 2007 at 12:17:25PM +0100, Michael Niedermayer wrote:
> > > > > 
> > > > > you can test palette support with
> > > > > -vf scale,format=bgr8,scale
> > > > > 
> > > > > rgb8 doesnt work as the init code is missing (bug in vf_scale.c not in the 
> > > > > swscaler!), -vf palette is affected as well
> > > > > you can also test it with videos like 8bpp.avi (i think that was from mphq?)
> > > > > 
> > > > > if something doesnt work then please first test that -vf palette,scale works
> > > > > also try valgrind to ensure that there are no bugs in the demuxer or decoder
> > > > > (especially important for the game formats)
> > > > 
> > > > It works for you?  
> > > 
> > > of course it does ...
> > > 
> > > > With -vf scale,format=bgr8,scale I get psychedelic
> > > > colors ...
> > > 
> > > did you forget svn up? i also had these colors before i fixed vf_scale.c
> > 
> > wait, do you use a big endian architecture? if so palette support doesnt work
> > as ffmpeg uses native endian and mplayer non native endian so theres a
> > missmatch between the swscaler and mplayer on big endian
> 
> I tested on both x86 and PPC.  I'll run distclean and empty compiler
> caches everywhere and report back later.

I still get psychedelic colors on both PPC and x86.  Any detailed
information I can provide?

Diego