[MPlayer-cvslog] r22237 - trunk/libmpcodecs/vf_scale.c

[Diego Biurrun]

On Sat, Feb 17, 2007 at 01:35:15PM +0100, Michael Niedermayer wrote:
> 
> On Sat, Feb 17, 2007 at 01:20:31PM +0100, Michael Niedermayer wrote:
> > 
> > On Sat, Feb 17, 2007 at 12:48:24PM +0100, Diego Biurrun wrote:
> > > On Sat, Feb 17, 2007 at 12:17:25PM +0100, Michael Niedermayer wrote:
> > > > 
> > > > On Sat, Feb 17, 2007 at 04:04:44AM +0100, Michael Niedermayer wrote:
> > > > > On Sat, Feb 17, 2007 at 03:30:15AM +0100, Michael Niedermayer wrote:
> > > > > > 
> > > > > > On Sat, Feb 17, 2007 at 03:05:30AM +0100, Michael Niedermayer wrote:
> > > > > > > 
> > > > > > > On Sat, Feb 17, 2007 at 01:31:32AM +0100, Diego Biurrun wrote:
> > > > > > > > On Fri, Feb 16, 2007 at 10:17:41PM +0100, michael wrote:
> > > > > > > > > 
> > > > > > > > > Log:
> > > > > > > > > PAL8 ...
> > > > > > > > 
> > > > > > > > I'm getting crashes left and right with game format samples.  Here's a
> > > > > > > > selection:
> > > > > > > > 
> > > > > > > > http://samples.mplayerhq.hu/game-formats/interplay-mve/baldursgate-camp.mve
> > > > > > > 
> > > > > > > also crashes with -vo null which doesnt use the scaler
> > > > > > 
> > > > > > btw, valgrind output would be welcome ...
> > > > > > and ffmpeg without the swscaler crashes too ...
> > > > > 
> > > > > ok, ive fixed 3 bugs (2 in the demuxer one in vd_ffmpeg.c) ill leave the
> > > > > rest to some other volunteer, both the old (-vf palette,scale) and new code 
> > > > > produce a black picture with mplayer, ffplay works
> > > > 
> > > > you can test palette support with
> > > > -vf scale,format=bgr8,scale
> > > > 
> > > > rgb8 doesnt work as the init code is missing (bug in vf_scale.c not in the 
> > > > swscaler!), -vf palette is affected as well
> > > > you can also test it with videos like 8bpp.avi (i think that was from mphq?)
> > > > 
> > > > if something doesnt work then please first test that -vf palette,scale works
> > > > also try valgrind to ensure that there are no bugs in the demuxer or decoder
> > > > (especially important for the game formats)
> > > 
> > > It works for you?  
> > 
> > of course it does ...
> > 
> > > With -vf scale,format=bgr8,scale I get psychedelic
> > > colors ...
> > 
> > did you forget svn up? i also had these colors before i fixed vf_scale.c
> 
> wait, do you use a big endian architecture? if so palette support doesnt work
> as ffmpeg uses native endian and mplayer non native endian so theres a
> missmatch between the swscaler and mplayer on big endian

I tested on both x86 and PPC.  I'll run distclean and empty compiler
caches everywhere and report back later.

> anyway, i dont want to fix all the mess i just want to remove imgconvert/rescale
> the sws palette code works the interface to mplayer is buggy, mplayer itself is
> buggy most demuxers and decoders handling palettes are buggy the code to pass
> palettes around is buggy, it can only work with single threaded apps ...
> 
> theres a lot of bugs not surprissingly as the feature is pretty much used by
> noone, but these are not related to imgconvert vs. sws

Yes, I assumed that you just triggered many bugs in unused code paths ..

Diego