[MPlayer-cvslog] r20579 - trunk/libmpdvdkit2/common.h

[Diego Biurrun]

On Sat, Nov 04, 2006 at 03:57:38PM -0500, Rich Felker wrote:
> On Wed, Nov 01, 2006 at 03:41:59PM +0100, diego wrote:
> > 
> > Modified:
> >    trunk/libmpdvdkit2/common.h
> > 
> > Log:
> > Typo: lseek --> lseek64, the former is not used in the code.
> > Fixes linking on MinGW.
> > 
> > --- trunk/libmpdvdkit2/common.h	(original)
> > +++ trunk/libmpdvdkit2/common.h	Wed Nov  1 15:41:59 2006
> > @@ -52,7 +52,7 @@
> >  
> >  /* several type definitions */
> >  #   if defined( __MINGW32__ )
> > -#       define lseek _lseeki64
> > +#       define lseek64 _lseeki64
> 
> This MUST be fixed in the code. The lseek64 function is invalid
> LFS-ism. Please revert and fix mpdvdkit instead, regardless of whether
> the upstream will accept the fix, since it's blatently wrong.

What's LFS?

Anyway, the code in common.h looks like this (unrelated lines removed):

#if defined( WIN32 )
#   if defined( __MINGW32__ )
#       define lseek64 _lseeki64
#   endif
#   if defined( _MSC_VER )
#   endif
#else
#   define lseek64 lseek
#endif

So lseek64 is replaced in the code except in the Visual Studio case, so
I believe this should be correct.

Diego