[MPlayer-cvslog] r20579 - trunk/libmpdvdkit2/common.h

Rich Felker dalias at aerifal.cx
Sat Nov 4 21:57:38 CET 2006


On Wed, Nov 01, 2006 at 03:41:59PM +0100, diego wrote:
> Author: diego
> Date: Wed Nov  1 15:41:59 2006
> New Revision: 20579
> 
> Modified:
>    trunk/libmpdvdkit2/common.h
> 
> Log:
> Typo: lseek --> lseek64, the former is not used in the code.
> Fixes linking on MinGW.
> 
> 
> Modified: trunk/libmpdvdkit2/common.h
> ==============================================================================
> --- trunk/libmpdvdkit2/common.h	(original)
> +++ trunk/libmpdvdkit2/common.h	Wed Nov  1 15:41:59 2006
> @@ -52,7 +52,7 @@
>  
>  /* several type definitions */
>  #   if defined( __MINGW32__ )
> -#       define lseek _lseeki64
> +#       define lseek64 _lseeki64

This MUST be fixed in the code. The lseek64 function is invalid
LFS-ism. Please revert and fix mpdvdkit instead, regardless of whether
the upstream will accept the fix, since it's blatently wrong.

Rich




More information about the MPlayer-cvslog mailing list