[MPlayer-cvslog] r21666 - trunk/libmpdemux/demux_audio.c

[Rich Felker]

On Mon, Dec 18, 2006 at 09:44:33PM +0100, Michael Niedermayer wrote:
> Hi
> 
> On Mon, Dec 18, 2006 at 04:14:23PM +0100, reimar wrote:
> > Author: reimar
> > Date: Mon Dec 18 16:14:23 2006
> > New Revision: 21666
> > 
> > Modified:
> >    trunk/libmpdemux/demux_audio.c
> > 
> > Log:
> > Require 12 consecutive MPEG-audio headers before detecting as audio.
> > Fixes misdetection of http://samples.mplayerhq.hu/FLV/flv_misdetected_as_mpa
> 
> i dont want to complain but there is no real upper bound on how many
> consecutive valid mp3 frames a container might have ...

Indeed this is incorrect; I seem to recall the limit once being higher
and being _lowered_ because some mp3 files were not playable. In any
case, a file should always be detected as mp3 when there is an id2v3
header at the beginning immediately followed by a valid string of mp3
headers, or when the mp3 headers start at the beginning of the file..

And yes if this will misdetect other files then the mp3 detection
needs to be moved later in the sequence, but not crippled like this!

Rich