[MPlayer-cvslog] r21666 - trunk/libmpdemux/demux_audio.c

[Reimar Döffinger]

Hello,
On Mon, Dec 18, 2006 at 09:44:33PM +0100, Michael Niedermayer wrote:
> On Mon, Dec 18, 2006 at 04:14:23PM +0100, reimar wrote:
> > Author: reimar
> > Date: Mon Dec 18 16:14:23 2006
> > New Revision: 21666
> > 
> > Modified:
> >    trunk/libmpdemux/demux_audio.c
> > 
> > Log:
> > Require 12 consecutive MPEG-audio headers before detecting as audio.
> > Fixes misdetection of http://samples.mplayerhq.hu/FLV/flv_misdetected_as_mpa
> 
> i dont want to complain but there is no real upper bound on how many
> consecutive valid mp3 frames a container might have ...

Well, there is nothing that would stop e.g. a MXF file from starting
with an AVI header etc.

> lavf-flv detection should somehow be tried before .mp3 or both should
> tried with more weight for flv ...

There sure is room for improvement here. I didn't have a really good
idea yet and it is rather low priority for me.
Maybe just adding a safelavf "demuxer" (within demux_lavf.c) that is probed
before other stuff and probes only certain specified formats might be a good idea.

Greetings,
Reimar Döffinger