[MPlayer-cvslog] CVS: main/libmpcodecs vf_cropdetect.c,1.11,1.12

[Guillaume POIRIER]

Hi,

On 7/26/05, Guillaume POIRIER <poirierg at gmail.com> wrote:
> Hi,
> 
> On 7/26/05, Diego Biurrun <diego at biurrun.de> wrote:
> > On Tue, Jul 26, 2005 at 02:26:41PM +0200, Guillaume POIRIER wrote:
> > >
> > > On 7/26/05, Reimar Döffinger CVS <syncmail at mplayerhq.hu> wrote:
> > > >
> > > > Modified Files:
> > > >         vf_cropdetect.c
> > > > Log Message:
> > > > restrict to YV12 since the default limit does not work well for anything else.
> > >
> > > Does that fix the wrong cropping limits detection when using "-vo null"?
> > > I think that in my case, with a MPEG-2 source, the problem was that
> > > the lavc MPEG-1 was loaded instead of the one supposed to be used
> > > (it's fixed when appending "-vfm libmpeg2").
> >
> > If it really only happens with FFmpeg and not with libmpeg2 then it's
> > something you should investigate in more detail, Michael will probably
> > want to have a look at it.
> 
> Probably, but to me it's logical that bad things happen when you try
> to read a MPEG-2 file with a MPEG-1 decoder. I'll have a "deeper" look
> at it.

In fact, it's not where the problem comes from. Here is what happen
when using -vf cropdetect and and -vo null:

Cannot load font: c:/windows/fonts/arial.ttf
Playing test.mpg.
MPEG-PS file format detected.
VIDEO:  MPEG2  720x480  (aspect 2)  29.970 fps  8000.0 kbps (1000.0 kbyte/s)
Opening video filter: [cropdetect]
==========================================================================
Opening video decoder: [mpegpes] MPEG 1/2 Video passthrough
VDec: vo config request - 720 x 480 (preferred csp: Mpeg PES)
Could not find matching colorspace - retrying with -vf scale...
Opening video filter: [scale]
Opening video filter: [lavc]
Could not find matching colorspace - retrying with -vf scale...
Opening video filter: [scale]
The selected video_out device is incompatible with this codec.
VDecoder init failed :(
Opening video decoder: [libmpeg2] MPEG 1/2 Video decoder libmpeg2-v0.4.0b
Selected video codec: [mpeg12] vfm:libmpeg2 (MPEG-1 or 2 (libmpeg2))
==========================================================================
Audio: no sound
Starting playback...
VDec: vo config request - 720 x 480 (preferred csp: Planar YV12)
VDec: using Planar YV12 as output csp (no 0)
Movie-Aspect is 1.33:1 - prescaling to correct movie aspect.
[mpeg1video @ 009F2068]framerate not set
Could not open codec.
FATAL: Cannot initialize video driver.

FATAL: Could not initialize video filters (-vf) or video output (-vo).


The problem is that lacv video filter gets loaded when it should not,
which triggers this error: "[mpeg1video @ 009F2068]framerate not set".
Appending -vfm ffmpeg or -vfm libmpeg2 "fixes" it.

Guillaume
-- 
I feel sorry for people who don't drink.
When they wake up in the morning, that's
as good as they're going to feel all day.
 -- Frank Sinatra