[MPlayer-cvslog] CVS: main/libmpcodecs ve_x264.c,1.33,1.34

[Diego Biurrun]

On Mon, Aug 22, 2005 at 01:33:41AM +0300, Ivan Kalvachev wrote:
> 2005/8/21, Diego Biurrun <diego at biurrun.de>:
> > On Sun, Aug 21, 2005 at 07:10:53PM +0300, Ivan Kalvachev wrote:
> > > 2005/8/18, Diego Biurrun <diego at biurrun.de>:
> > > >
> > > > Ivan, can you document this or revert the patch, please?
> > >
> > > Why, can't you document it instead?
> > > You wrote 3 times more text here. And you perfectly well know what it
> > > does and how.
> > 
> > I have no idea what it does and how and I really cannot be bothered to
> > find out because I have very little time at the moment.  Besides, our
> > CVS policy is clear, see DOCS/tech/cvs-howto.txt:
> > 
> > 11. Update the documentation if you change behavior or add features. If
> >     you are unsure how best to do this, send a patch to mplayer-docs,
> >     the documentation maintainers will review and commit your stuff.
> 
> Of course, You wrote it, haven't you?

I wrote it, but what I wrote down is what was agreed to on dev-eng.  Why
haven't you objected before if you don't like the rules?  It's been
there for almost a year...

> > I really don't want to flame and I'll gladly fix up and improve any man
> > page entry you come up with, but don't forget that there are many more
> > code than docs writers.  Everybody has to help with the docs, otherwise
> > they will inevitably become incomplete.
> > 
> > You wrote the code and understand what the option does, please come up
> > with something quickly, it should not take you longer than 5-10 minutes.
> > Ask me for help next time I'm on IRC if you need it.
> 
> I don't feel like writing an manual that you will reword anyway...

Pfff, sorry for helping you.  Seeing how grateful you are I'll think
twice before doing it in the future.

> don't loose more time and just do your job. And your jobs is not
> hunting developers to write manuals.

Don't tell me what my job is.  You are being rude and insolent, quit the
flaming now, it is completely uncalled for.

That code is undocumented, you said it does not work and just hangs.  I
cannot see any justification to keep it in CVS.

Diego