[MPlayer-cvslog] CVS: main/libmpcodecs ve_x264.c,1.33,1.34

[Ivan Kalvachev]

2005/8/21, Diego Biurrun <diego at biurrun.de>:
> On Sun, Aug 21, 2005 at 07:10:53PM +0300, Ivan Kalvachev wrote:
> > 2005/8/18, Diego Biurrun <diego at biurrun.de>:
> > > On Fri, Jul 22, 2005 at 10:26:30AM +0200, Diego Biurrun wrote:
> > > > On Thu, Jul 21, 2005 at 08:54:32PM +0300, Ivan Kalvachev wrote:
> > > > > On 7/21/05, Diego Biurrun <diego at biurrun.de> wrote:
> > > > > > On Tue, Jul 19, 2005 at 07:56:53PM +0200, Ivan Kalvachev CVS wrote:
> > > > > > >
> > > > > > > Modified Files:
> > > > > > >       ve_x264.c
> > > > > > > Log Message:
> > > > > > > add (no)visualize options
> > > > > > >
> > > > > > > --- ve_x264.c 11 Jul 2005 19:02:39 -0000      1.33
> > > > > > > +++ ve_x264.c 19 Jul 2005 17:56:51 -0000      1.34
> > > > > > > @@ -167,6 +168,8 @@
> > > > > > > +    {"visualize", &visualize, CONF_TYPE_FLAG, 0, 0, 1, NULL},
> > > > > > > +    {"novisualize", &visualize, CONF_TYPE_FLAG, 0, 1, 0, NULL},
> > > > > >
> > > > > > Where's the man page update? ;)
> > > > >
> > > > > I don't think I should document option that doesn't work.
> > > > > Not yet :)
> > > > > It just hangs for me.
> > > >
> > > > Why do you commit non-working code in the first place?
> > > >
> > > > I disagree completely about not committing documentation updates. Please
> > > > always commit the documentation together with the code. Otherwise it
> > > > will get forgotten and the documentation remain incomplete. If the
> > > > feature is alpha or even broken, mark it as such in the documentation,
> > > > but document it anyway.
> > >
> > > Ivan, can you document this or revert the patch, please?
> >
> > Why, can't you document it instead?
> > You wrote 3 times more text here. And you perfectly well know what it
> > does and how.
> 
> I have no idea what it does and how and I really cannot be bothered to
> find out because I have very little time at the moment.  Besides, our
> CVS policy is clear, see DOCS/tech/cvs-howto.txt:
> 
> 11. Update the documentation if you change behavior or add features. If
>     you are unsure how best to do this, send a patch to mplayer-docs,
>     the documentation maintainers will review and commit your stuff.

Of course, You wrote it, haven't you?

> 
> I really don't want to flame and I'll gladly fix up and improve any man
> page entry you come up with, but don't forget that there are many more
> code than docs writers.  Everybody has to help with the docs, otherwise
> they will inevitably become incomplete.
> 
> You wrote the code and understand what the option does, please come up
> with something quickly, it should not take you longer than 5-10 minutes.
> Ask me for help next time I'm on IRC if you need it.

I don't feel like writing an manual that you will reword anyway...
don't loose more time and just do your job. And your jobs is not
hunting developers to write manuals.