[Mplayer-cvslog] CVS: main/postproc rgb2rgb.h,1.28,1.29

[Alban Bedel]

Hi Pierre Lombard,

on Sun, 21 Sep 2003 02:46:48 +0200 you wrote:

> * Dominik 'Rathann' Mierzejewski <dominik at rangers.eu.org> [2003-09-20
> 16:00]:
> > On Saturday, 20 September 2003, pl CVS wrote:
> > > Update of /cvsroot/mplayer/main/postproc
> > > In directory mail:/var/tmp.root/cvs-serv21631
> > > 
> > > Modified Files:
> > > 	rgb2rgb.h 
> > > Log Message:
> > > printf() requires stdio.h
> > 
> > No! This was proposed by me couple of months ago and rejected by Alex,
> > because the code is obsolete:
> > [...]
> > Applied the old ones [...], but the yuv2rgb stuff I will
> > leave so, as you saw, there're only two files depending on those funcs
> > (vo_fbdev & vo_directfb), and after fixing them, the obsoleted funcs
> > are going to be removed.
> > [...]
> > 
> > See the thread
> > main: [BUG?] draw_slice in vd_libmpeg2.c and [PATCH] some warning
> > fixes on 01/06/2003.
> > Please reverse.
> 
> Ok.
> 
> I had sent it in some previous mail but got no reaction so I supposed it
> would be ok.  Just leaving a comment instead so that this peculiar fix
> doesn't appear again in the future.
imho it's one of the real problem currently. Lot's of patch get simply
ignored and in particular the "wrong" ones. As most patch are just ignored
ppl just go on and commit (wich is normal imho).
So pls guys when you see a patch and know that it will break smthg
speak up !!!!!
	Albeu

-- 

Everything is controlled by a small evil group
to which, unfortunately, no one we know belongs.