[Mplayer-cvslog] CVS: main/libmpdemux stream.c,1.60,1.61

D Richard Felker III dalias at aerifal.cx
Tue Apr 8 03:02:29 CEST 2003

On Mon, Apr 07, 2003 at 10:51:10PM +0200, Andreas Hess wrote:
> On Mon, Apr 07, 2003 at 10:44:10PM +0200, Ross Finlayson CVS wrote:
> > Oops, I just noticed albeu's revision 1.58 - so I backed out the
> > "s->fd == NULL" test once again.  I'll need to come up with some other
> > way of fixing this so that it works properly on Solaris...
> Why don't you just add a test for !s->fd in stream_seek_long() ?

Because it's wrong!!! -1 (or any negative number) is the way you
signal invalid/no fd. 0 is a perfectly valid file descriptor! Whatever
code is setting s->fd to 0 for "no fd" should be fixed.


More information about the MPlayer-cvslog mailing list