[Mplayer-cvslog] CVS: main/libmpdemux stream.c,1.60,1.61

[Andreas Hess]

On Mon, Apr 07, 2003 at 09:02:29PM -0400, D Richard Felker III wrote:
> On Mon, Apr 07, 2003 at 10:51:10PM +0200, Andreas Hess wrote:
> > On Mon, Apr 07, 2003 at 10:44:10PM +0200, Ross Finlayson CVS wrote:
> > > Oops, I just noticed albeu's revision 1.58 - so I backed out the
> > > "s->fd == NULL" test once again.  I'll need to come up with some other
> > > way of fixing this so that it works properly on Solaris...
> > 
> > Why don't you just add a test for !s->fd in stream_seek_long() ?
> 
> Because it's wrong!!! -1 (or any negative number) is the way you
> signal invalid/no fd. 0 is a perfectly valid file descriptor! Whatever
> code is setting s->fd to 0 for "no fd" should be fixed.

But as I understood Ross, on Solaris it isn't a valid file descriptor.
So testing for !s->fd (and a #ifdef) should be enough.