[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.26,1.27

[Michael Niedermayer]

Hi

On Monday 15 July 2002 01:28, Arpi wrote:
> Hi,
>
> > -    //FIXME check if lavc codec supports dr1
> > +    int dr1= ctx->do_dr1=0;
>
> that =0 disabled DR even if codec and vo supports it. is it there by
> reason?
yes, its not 100% working yet (i have a few files which get messed up, iam 
currently working on this), i mentioned in cvs log that its disabled, didnt 
i? btw the bug is in lavc not mplayer ...

>
> anyway very nice work, just examined the way you did it in vd_ffmpeg!
:))

>
> about this:
>     mpi= mpcodecs_get_image(sh,MP_IMGTYPE_IPB, flags,
> // MN: arpi, is the next line ok? (i doubt it), its needed for height%16!=0
> file (width+15)&(~15), (height+15)&(~15));
>
> it is OK, the only way to get it now.
> the question is what do you need: stride%16==0 or
> stride>=((width+15)&(~15)) ? in later case, this is the right code. for the
> former, i'll implement ACCEPT_ALIGNED_STRIDE flag, it's a limited variant
> of ACCEPT_STRIDE.
i need stride >= (width+15)&(~15) but it must be the same for all MPIs (last, 
next & the one for b frames) allthough for speed reasons (aligned mmx stuff) 
stride%16==0 is a good idea too

>
> anyway all the mpi stuff you did looks ok for me, congrats! ;)
:))))))))))

[...]

Michael