[Mplayer-cvslog] CVS: main/libmpcodecs vd_ffmpeg.c,1.26,1.27

Arpi arpi at thot.banki.hu
Mon Jul 15 01:28:00 CEST 2002


Hi,

> -    //FIXME check if lavc codec supports dr1
> +    int dr1= ctx->do_dr1=0;

that =0 disabled DR even if codec and vo supports it. is it there by reason?

anyway very nice work, just examined the way you did it in vd_ffmpeg!

about this:
    mpi= mpcodecs_get_image(sh,MP_IMGTYPE_IPB, flags,
// MN: arpi, is the next line ok? (i doubt it), its needed for height%16!=0 file
                        (width+15)&(~15), (height+15)&(~15));

it is OK, the only way to get it now.
the question is what do you need: stride%16==0 or stride>=((width+15)&(~15)) ?
in later case, this is the right code. for the former, i'll implement
ACCEPT_ALIGNED_STRIDE flag, it's a limited variant of ACCEPT_STRIDE.

anyway all the mpi stuff you did looks ok for me, congrats! ;)


A'rpi / Astral & ESP-team

--
Developer of MPlayer, the Movie Player for Linux - http://www.MPlayerHQ.hu



More information about the MPlayer-cvslog mailing list