[MEncoder-users] Mencoder soft telecine broken; fix included

Christopher "Monty" Montgomery xiphmont at gmail.com
Fri Sep 28 07:03:05 CEST 2007


Oops, resending from the subscribed mailing address....

All mpeg2 soft telecine appears to be broken due to a bitmask bug
introduced in February (commit 23348), when a code move mutated a 0x10
into a 0x20 causing sequence extensions to never be processed.

A second bug is a mismask at muxer_mpeg.c:1614. The mask should be
0x7d not 0xfd as bff_mask sets/clears bits 7 and 1, not just bit 1.
The dgpullup code (that this is taken from) also uses 0x7d.

svn diff attached.  Fix tested working here with film->NTSC and
PAL->NTSC direct soft telecine.  Please let me know if this fix is
somehow incorrect-- I'm using it to burn a whole bunch of DVDs right
now :-)

Monty
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch.txt
URL: <http://lists.mplayerhq.hu/pipermail/mencoder-users/attachments/20070928/95fc658b/attachment.txt>


More information about the MEncoder-users mailing list