[FFmpeg-soc] [PATCH] rtsp tunneling

[Martin Storsjö]

On Mon, 7 Jun 2010, Josh Allmann wrote:

> Luca, Martin, any more comments?

#3 seemed ok, no comments, applied.

The lack of a #4 in this series indicates that you hadn't rebased this on 
top of the latest master/trunk.

... which bit me when I tried to apply #5, which didn't apply cleanly. So 
make sure you rebase on top of the latest versions regularly, especially 
if there are other changes to the areas you're working on!

Except for that, it seemed ok, so applied.

I added an error message in ff_rtsp_send_cmd_with_content_async if you try 
to send body data with the request in tunneling mode, since the body data 
needs to be base64 encoded together with the request. Currently, only the 
RTSP muxer does such requests (for which the HTTP tunneling is disabled), 
but I added it to make sure noone runs into problems if someone adds such 
requests to the RTSP demuxer. 

Despite all the other feedback, congrats on getting the first major 
feature committed.

// Martin