[FFmpeg-soc] [soc]: r4387 - als/ffmpeg-patches/hack4als.patch

[Thilo Borgmann]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

> I dunno much but av_find_stream_info tries to decode a few frames and
> get the necessary parameters, following which the audio output is
> opened in stream_component_open. So it should work. If it doesn't,
> then its probably a bug and in which case we should investigate
> further.
> 

All my fault. I missed that the decoders init function is called to get
these parameters before the described error occurs in ffplay. Your patch
extract these information and therefore it seemed to be necessary in my
eyes to get this going in ffplay.

Justin suggests a function for reading basic parameters which shall be
shared by libavformat/libavcodec to avoid redundancy.

I will try to implement this soon to replace this hack4als.patch and let
the decoders init function do this work then.


>> Therefore, it is needed if I do want to write the decoder and test its
>> features. Isn't it?
> 
> And its a lossless codec right? So why not write a script which runs
> through the als test vectors and does a comparison with the reference
> waveform. This is very useful for regressions also. You need not
> "enable" all the test vectors for now, just the subtools/features you
> are implementing initially. Anyway, this is just a sidenote :)
> 

Sounds interesting. I will have a look at this - thanks!

Thilo
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFKKq7bQjO++GdR9a4RAnFUAKCEca02M2e5yehxvtEf6Azomm1rFQCdH0ZR
OpPsscCBPuChB1aYW85BxgA=
=3fHK
-----END PGP SIGNATURE-----