[FFmpeg-soc] [PATCH] Some fast_bilinear patches.

[Ramiro Polla]

On Mon, Jul 27, 2009 at 3:52 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
> On Mon, Jul 27, 2009 at 03:27:58AM -0300, Ramiro Polla wrote:
>> On Fri, Jul 24, 2009 at 10:05 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
>> > On Thu, Jul 23, 2009 at 10:56:34PM -0300, Ramiro Polla wrote:
>> >> Attached are some patches for the fast bilinear scaler, while I wait
>> >> on Michael's answer on the previous message regarding fast_bilinear.
>> >>
>> >> Hmm, should these patches go to -devel or -soc?
>> >>
>> >> Ramiro Polla
>> >
>> >>  swscale.c |   61 +++++++++++++++++++++++++++++--------------------------------
>> >>  1 file changed, 29 insertions(+), 32 deletions(-)
>> >> d369af493c0c7e0f5d040ed71c1b232cf30a31bc  0001-Avoid-duplication-in-initMMX2HScaler.patch
>> >> From 05c4bf02481265155b7d25438e9b32ceefcd578e Mon Sep 17 00:00:00 2001
>> >> From: Ramiro Polla <ramiro at macbuntu.(none)>
>> >> Date: Thu, 23 Jul 2009 21:56:57 -0300
>> >> Subject: [PATCH] Avoid duplication in initMMX2HScaler()
>> >
>> > might be ok but it isnt particularely readable so iam not sure ...
>>
>> What's not readable? The resulting code or the patch? There's
>
> the patch
>
>
>> currently 1 patch for factorization, then a cleanup which indents and
>> changes some {}s, and the last patch (which you didn't comment) is
>> unrelated. Should I try adding intermediate steps to make the
>> factorization more clear?
>
> if you can easily make it more readable please do

Attached patches should make it much more readable, and have no
unrelated cosmetics. The resulting code looks nicer too IMHO.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-MMX2-scaler-add-variable-to-ease-factorization-of-i.patch
Type: text/x-diff
Size: 1766 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090727/d7f797ca/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-MMX2-scaler-factorize-initMMX2Scaler.patch
Type: text/x-diff
Size: 3576 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090727/d7f797ca/attachment-0001.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-Cosmetics.patch
Type: text/x-diff
Size: 2862 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090727/d7f797ca/attachment-0002.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0004-MMX2-scaler-Determine-funnyCode-size-at-runtime.patch
Type: text/x-diff
Size: 5294 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-soc/attachments/20090727/d7f797ca/attachment-0003.patch>