[FFmpeg-soc] [PATCH] Some fast_bilinear patches.

[Ramiro Polla]

Hi,

On Fri, Jul 24, 2009 at 10:05 AM, Michael Niedermayer<michaelni at gmx.at> wrote:
> On Thu, Jul 23, 2009 at 10:56:34PM -0300, Ramiro Polla wrote:
>> Attached are some patches for the fast bilinear scaler, while I wait
>> on Michael's answer on the previous message regarding fast_bilinear.
>>
>> Hmm, should these patches go to -devel or -soc?
>>
>> Ramiro Polla
>
>>  swscale.c |   61 +++++++++++++++++++++++++++++--------------------------------
>>  1 file changed, 29 insertions(+), 32 deletions(-)
>> d369af493c0c7e0f5d040ed71c1b232cf30a31bc  0001-Avoid-duplication-in-initMMX2HScaler.patch
>> From 05c4bf02481265155b7d25438e9b32ceefcd578e Mon Sep 17 00:00:00 2001
>> From: Ramiro Polla <ramiro at macbuntu.(none)>
>> Date: Thu, 23 Jul 2009 21:56:57 -0300
>> Subject: [PATCH] Avoid duplication in initMMX2HScaler()
>
> might be ok but it isnt particularely readable so iam not sure ...

What's not readable? The resulting code or the patch? There's
currently 1 patch for factorization, then a cleanup which indents and
changes some {}s, and the last patch (which you didn't comment) is
unrelated. Should I try adding intermediate steps to make the
factorization more clear?

> [...]
>
>>  swscale_template.c |   32 ++++++++++++++++----------------
>>  1 file changed, 16 insertions(+), 16 deletions(-)
>> 4fdafc55f85b4310929f24bf242826adf7e47218  0003-Fix-asm-comments-for-x86-fast_bilinear.patch
>> From 96c44c351bba02aa0f28f225965224ff2805d8a0 Mon Sep 17 00:00:00 2001
>> From: Ramiro Polla <ramiro at macbuntu.(none)>
>> Date: Thu, 23 Jul 2009 22:06:07 -0300
>> Subject: [PATCH] Fix asm comments for x86 fast_bilinear.
>
> probably ok
>
> [...]
>
>
>>  swscale_template.c |   36 ++++++++++++------------------------
>>  1 file changed, 12 insertions(+), 24 deletions(-)
>> 59bfb9a898ef3cba8ebef08bce2685b03d433d51  0004-Factorize-FAST_BILINEAR_X86.patch
>> From e781b5986f8dd88cf50fb0321730f970d54f045f Mon Sep 17 00:00:00 2001
>> From: Ramiro Polla <ramiro at macbuntu.(none)>
>> Date: Thu, 23 Jul 2009 22:21:20 -0300
>> Subject: [PATCH] Factorize FAST_BILINEAR_X86.
>
> ok if obj file  matches

Applied.